Put back clang formatting, via pre-commit this time #9158
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9158
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit e837cb9 with merge base f52c4f1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have a complicated way of formatting Cpp code via a custom `.github/scripts/run-clang-format.py
I temporarily deactivated clang formatting in the past to avoid conflicts with fbcode.
Now that fbcode formatting is also deactivated, we can put back clang formatting. Instead of re-using the complex
.github/scripts/run-clang-format.pysetup, we now use pre-commit to run clang, just like we do in torchcodec.